Skip to content

refact: make resource_utils to use project defined exception and refact code for readability#274

Merged
darkrush merged 9 commits intoccprocessor:devfrom
darkrush:test_multi_process_lock
Mar 6, 2025
Merged

refact: make resource_utils to use project defined exception and refact code for readability#274
darkrush merged 9 commits intoccprocessor:devfrom
darkrush:test_multi_process_lock

Conversation

@darkrush
Copy link
Copy Markdown
Collaborator

@darkrush darkrush commented Mar 6, 2025

make resource_utils to use project defined exception and refact code for readability
Move FileLock in llm_web_kit/model/resource_utils/download_assets.py to FileLockContext in llm_web_kit/model/resource_utils/utils.py

@darkrush darkrush merged commit 1c498d5 into ccprocessor:dev Mar 6, 2025
3 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
llm_web_kit/model/resource_utils/unzip_ext.py 78.12% 7 Missing ⚠️
...lm_web_kit/model/resource_utils/download_assets.py 76.47% 4 Missing ⚠️
llm_web_kit/config/cfg_reader.py 33.33% 2 Missing ⚠️
llm_web_kit/model/resource_utils/boto3_ext.py 88.88% 1 Missing ⚠️
llm_web_kit/model/resource_utils/utils.py 97.77% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #274      +/-   ##
==========================================
- Coverage   90.68%   89.21%   -1.48%     
==========================================
  Files         116       80      -36     
  Lines        6914     5478    -1436     
==========================================
- Hits         6270     4887    -1383     
+ Misses        644      591      -53     
Files with missing lines Coverage Δ
...model/resource_utils/singleton_resource_manager.py 100.00% <100.00%> (ø)
llm_web_kit/model/resource_utils/boto3_ext.py 82.00% <88.88%> (-0.98%) ⬇️
llm_web_kit/model/resource_utils/utils.py 97.77% <97.77%> (ø)
llm_web_kit/config/cfg_reader.py 73.33% <33.33%> (+1.90%) ⬆️
...lm_web_kit/model/resource_utils/download_assets.py 95.31% <76.47%> (+3.64%) ⬆️
llm_web_kit/model/resource_utils/unzip_ext.py 84.61% <78.12%> (-11.04%) ⬇️

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant